-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Select op support #1338
Select op support #1338
Conversation
lib/Conversion/TTIRToTTIRDecomposition/TTIRToTTIRDecomposition.cpp
Outdated
Show resolved
Hide resolved
test/ttmlir/Dialect/TTIR/select/select_decomposition_tests.mlir
Outdated
Show resolved
Hide resolved
* Add select op to TTIR * Decompose select op to TTIR slices and concat optionally * Unit tests
98b9b67
to
719079e
Compare
This |
Talked offline, seems like we just need a better name for this op. @nvukobratTT is it okay to change op names in Forge? Did you manually choose this name (Select) or was it chosen based on TVM or something? |
It's okay to change op names in Forge, if we figure out that other is better suited :)) Most of the ops on Forge are inspired by TVM. However, I wouldn't limit us to use those names, if we find ones that are more suitable and aligned with TTIR and other frontends. @mrakitaTT @rpavlovicTT I don't have full context, so feel free to send you proposal with a bit more details :)) |
Select op support * Add select op to TTIR * Decompose select op to TTIR slices and concat optionally * Unit tests
Fixes #1179