Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ops] Add TTIR isfinite OP #634

Closed
mrakitaTT opened this issue Sep 6, 2024 · 2 comments · Fixed by #956
Closed

[Ops] Add TTIR isfinite OP #634

mrakitaTT opened this issue Sep 6, 2024 · 2 comments · Fixed by #956
Assignees
Labels
MLIR Ops Issues related to MLIR dialect ops and their implementations

Comments

@mrakitaTT
Copy link
Contributor

We should add isfinite OP to TTIR and TTNN dialects and then map it to ttnn.isfinite OP.

@sdjordjevicTT
Copy link
Contributor

sdjordjevicTT commented Oct 31, 2024

Can we please open ops tasks under the MLIR Dialect / Passes component to consolidate them into one place? There were a few cases when a few folks were working on the same op, hence I want to avoid that.

@mrakitaTT
Copy link
Contributor Author

@sdjordjevicTT Sure, sorry about that! We've also had couple instances of folks working on the same op either because they forget to assign themselves to issue or they open separate duplicate issue etc, so I totally understand the pain. This op in particular was one of those :) We've recently had a push through the whole list of StableHLO ops and we've opened task for each under StableHLO Conversion component, so that we have unique list people can take tasks from. Those tasks encompass whole process of supporting StableHLO op: adding tests in frontends, implementing conversion from StableHLO, making necessary changes in TTIR/TTNN, changes in runtime, etc. Ideally we should've opened separate tasks for each part of the work but we wanted to have this list asap and also it would be hard to track effort completion across multiple repos/components. We can now open separate tasks for each op that requires changes in TTIR/TTNN under MLIR Dialect / Passes component, let me talk with @AleksKnezevic to figure out how best to get to this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MLIR Ops Issues related to MLIR dialect ops and their implementations
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants