-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support tt-metal semaphores #919
Conversation
ce53db7
to
7de191f
Compare
7de191f
to
58e1fae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! Minor comments inline
@@ -187,6 +199,18 @@ class TTMetalToEmitCOpaqueRewriter : public OpConversionPattern<SourceOp> { | |||
return name; | |||
} | |||
|
|||
ArrayAttr getTemplateArgs(SourceOp op) const { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have addded similar function for reduce template args, I guess you didn't rebase yet.
Nice changes, few small comments, but overall looks good. |
61de687
to
28b9d4a
Compare
@nsmithtt / @xanderchin with regard to #915, please re-review. The existing comments have been addressed, and this branch rebased. Ready for merge. |
28b9d4a
to
627222a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks @jdesousa-TT for revitalizing this one.
Fix #915
Add support for all tt-metal semaphore functions, as well as some utility functions that are useful for using semaphores through compiler
For example, code below
will generate kernel code
TODO
tt_l1_ptr
properly