Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make use of PJRT_HostBufferSemantics to avoid unnecessarily copying host buffers #244

Open
mrakitaTT opened this issue Feb 6, 2025 · 0 comments
Assignees

Comments

@mrakitaTT
Copy link
Contributor

With change #220 we are fixing host buffer ownership issues by always creating copy of the host buffer. We can avoid doing so depending on the PJRT_HostBufferSemantics given to us by PJRT API caller. For example when semantic is PJRT_HostBufferSemantics_kImmutableUntilTransferCompletes we can just use the given host buffer and call done_with_host_buffer.ready() after executing in runtime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants