Render duration and port as JSON strings #1034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This a) avoids loss of information and b) makes it such that the user can directly use the output value in another query.
dominiklohmann
force-pushed
the
story/ch19098/duration-port-presentation
branch
from
df937bc
to
2ec3566
Compare
dominiklohmann
commented
Aug 28, 2020
Comment on lines
-82
to
-84
| // TODO: convert() generates a string, while our unit tests expect a | ||
| // number. Eventually, we're probably going to drop the protocol | ||
| // part but convert() and print() should be consistent regardless. |
There was a problem hiding this comment.
Note for the reviewer: convert() has been able to convert strings to duration/port for a while now.
tobim
approved these changes
Sep 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This a) avoids loss of information and b) makes it such that the user can directly use the output value in another query.