Fix merging of source status objects #1109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominiklohmann
force-pushed
the
story/ch19323/deep-merge-status
branch
3 times, most recently
from
7ee4aae
to
cf42956
Compare
tobim
requested changes
Oct 22, 2020
Unlike for other merge operations, for the status we want to recurse deep into the object structure and merge array contents instead of overwriting arrays. This fixes an issue that caused only the sources' status to show up in the output of `vast status` that replied last.
dominiklohmann
force-pushed
the
story/ch19323/deep-merge-status
branch
from
cf42956
to
8ff498b
Compare
tobim
reviewed
Oct 22, 2020
tobim
approved these changes
Oct 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📔 Description
Unlike for other merge operations, for the status we want to recurse deep into the object structure and merge array contents instead of overwriting arrays. This fixes an issue that caused only the sources' status to show up in the output of
vast status --detailedthat replied last.I verified this to work locally. We don't have an integration test that covers this.
📝 Checklist
🎯 Review Instructions
Please run this locally for testing. We do not have an integration test that covers this.