Don't enable automatic connections by default #1110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobim
reviewed
Oct 22, 2020
mavam
changed the title
mavam
requested changes
Oct 22, 2020
lava
force-pushed
the
topic/log-format
branch
from
01f25e1
to
98c1175
Compare
Disable the `middleman.enable-automatic-connections` option by default to prevent VAST from opening a random public port, and since we're not currently linking multiple VAST instances in a mesh anyways.
lava
force-pushed
the
topic/log-format
branch
from
98c1175
to
3a00031
Compare
mavam
approved these changes
Oct 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable the
middleman.enable-automatic-connectionsoption by default to prevent VAST from opening a random public port, and since we're not currently linking multiple VAST instances in a mesh anyways.