Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix YAML syntax errors in example config #1145

Merged
merged 8 commits into from
Nov 9, 2020
Merged

Fix YAML syntax errors in example config #1145

merged 8 commits into from
Nov 9, 2020

Conversation

mavam
Copy link
Member

@mavam mavam commented Nov 5, 2020 •
edited
Loading

📔 Description

The example YAML config file contained syntax errors.

📝 Checklist

  • All user-facing changes have changelog entries.
  • The PR description contains instructions for the reviewer, if necessary.

🎯 Review Instructions

File-by-file.

@mavam mavam requested a review from tobim November 5, 2020 10:52
@mavam mavam marked this pull request as ready for review November 5, 2020 10:52
@mavam mavam added the bug Incorrect behavior label Nov 5, 2020
@tobim
Copy link
Member

tobim commented Nov 7, 2020

@mavam The integration tests work as they should now.

I also fixed a few entries in the example file and added the parameters for the index.

tobim
tobim approved these changes Nov 7, 2020
View reviewed changes
Copy link
Member

@tobim tobim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally.

@mavam mavam merged commit d5018fe into master Nov 9, 2020
@mavam mavam deleted the story/ch20435 branch November 9, 2020 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobim tobim tobim approved these changes

Assignees
No one assigned
Labels
bug Incorrect behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mavam @tobim