-
-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show file size information in lsvast #1149
Conversation
f710eaf
to
78235bf
Compare
There is a lot of code for just formatting. How about using |
78235bf
to
6371edb
Compare
6371edb
to
d3cea87
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still getting hex output for the number of rows. Am I doing something wrong?
d3cea87
to
42dbdb1
Compare
No, I didn't realize |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this with my local DB, both using just the dir as argument and -h
. Looks good. Just one small change request regarding the representation of plain bytes.
42dbdb1
to
a8f0852
Compare
a8f0852
to
845e6b9
Compare
Add some options to lsvast to be able to optionally print the on-disk sizes of certain data structures in the partition and segment flatbuffers.
845e6b9
to
ce207ed
Compare
📔 Description
📝 Checklist
🎯 Review Instructions