Add domain concept and enhance uri + hostname #1150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0snap
approved these changes
Nov 9, 2020
There was a problem hiding this comment.
I tested this by adding the changes manually to my existing vast schemas and restarting vast. I then verified via vast status --debug that the concepts are loaded and merged and searched data using the concept predicates. The search was successful.
{
"VAST": "2020.10.29-74-g46171424",
"CAF": "0.17.6",
"Apache Arrow": "1.0.0",
"PCAP": "libpcap version 1.9.1 (with TPACKET_V3)",
"jemalloc": "5.2.1-0-gea6b3e973b477b8061e0076bb257dbd7f3faa756"
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📔 Description
This PR includes enhancements for some concepts that are especially helpful for retro matching.
📝 Checklist