Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show meta index size in vast status #1193

Merged
merged 4 commits into from
Nov 24, 2020
Merged

Show meta index size in vast status #1193

merged 4 commits into from
Nov 24, 2020

Conversation

lava
Copy link
Member

@lava lava commented Nov 23, 2020 •
edited
Loading

📔 Description

📝 Checklist

  • All user-facing changes have changelog entries.
  • The changes are reflected on docs.tenzir.com/vast, if necessary.
  • The PR description contains instructions for the reviewer, if necessary.

🎯 Review Instructions

Review commits independently.

@lava lava force-pushed the topic/meta-index-size-status branch from b750af7 to ae0b90b Compare November 23, 2020 14:32
dominiklohmann
dominiklohmann reviewed Nov 23, 2020
View reviewed changes
Copy link
Member

@dominiklohmann dominiklohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just an initial look at the code.

libvast/vast/address_synopsis.hpp Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
libvast/src/system/index.cpp Outdated Show resolved Hide resolved
@lava lava force-pushed the topic/meta-index-size-status branch from ae0b90b to 4be8cb6 Compare November 23, 2020 15:11
@dominiklohmann dominiklohmann added the feature New functionality label Nov 23, 2020
dominiklohmann
dominiklohmann approved these changes Nov 23, 2020
View reviewed changes
Copy link
Member

@dominiklohmann dominiklohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I ran this locally, and it works as expected.

I did not verify the calculated numbers, but the person I'd ask here would be @lava anyways.

libvast/vast/meta_index.hpp Outdated Show resolved Hide resolved
libvast/vast/address_synopsis.hpp Outdated Show resolved Hide resolved
@lava
Update comments for partition_synopsis
01e3819
@lava
Fix computation of bitvector::capacity()
365a545
@lava
Dont show concept descriptions in detailed status
7a6c4c2 
Printing the human-readable description for every field
in a concept adds hundreds of lines to the vast status
output, preventing operators from getting a quick system
overview at a glance.
@lava
Print meta index size on 'vast status'
102365b
@lava lava force-pushed the topic/meta-index-size-status branch from 4be8cb6 to 102365b Compare November 23, 2020 16:11
@lava lava merged commit af9d94a into master Nov 24, 2020
@lava lava deleted the topic/meta-index-size-status branch November 24, 2020 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominiklohmann dominiklohmann dominiklohmann approved these changes

Assignees
No one assigned
Labels
feature New functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lava @dominiklohmann