Detect and handle breaking changes in schemas #1195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mavam
requested changes
Nov 23, 2020
I've added a unit test as a separate commit. It isn't beautiful, but it works. |
mavam
reviewed
Nov 24, 2020
mavam
previously requested changes
Nov 24, 2020
dominiklohmann
force-pushed
the
topic/schema-mismatch-detection
branch
3 times, most recently
from
3cf4080
to
55a0649
Compare
dominiklohmann
dismissed
mavam’s stale review
Addressed and outdated; further feedback discussed via Slack.
|
This should be reviewed by @tobim after our Slack call yesterday on the matter. The last commit is the most important one here. |
tobim
requested changes
Nov 26, 2020
When changing schemas such that types are no longer a superset of previous versions of the same type, VAST may end up in a state where it cannot import events of that type. This change makes the type registry forget about incompatible versions of types automatically when a new and incompatible type is registered.
The previous commit made this one really obvious.
Co-authored-by: Matthias Vallentin <matthias@tenzir.com>
Now it's truly recursive and unit-tested on its own.
Co-authored-by: Matthias Vallentin <matthias@tenzir.com>
Instead of erasing incompatible versions, move the most recent version to the front so it is correctly used by all the readers.
dominiklohmann
force-pushed
the
topic/schema-mismatch-detection
branch
from
699b8d5
to
14b2758
Compare
dominiklohmann
commented
Nov 27, 2020
tobim
approved these changes
Nov 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📔 Description
When changing schemas such that types are no longer a superset of previous versions of the same type, VAST may end up in a state where it cannot import events of that type.
This change makes the type registry
forget about incompatible versions of types automatically when a new and incompatible type is registered.warn when this happens and ensures that newly registered types get priority over older types when importing data.📝 Checklist
🎯 Review Instructions
Commit-by-commit.