-
-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make it possible to dump concepts #1196
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work so far! Looking forward to reading the documentation of the command.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly nits.
Co-authored-by: Matthias Vallentin <matthias@tenzir.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Green light modulo two details:
- The changelog entry
- The
request
+actor_cast
issue
Let's not have this block the PR, it really is a non-issue; instead, we'll move forward with this as is once CI ran through. |
Fine by me iff you create a follow-up story for it. |
Actually figured this out myself: It doesn't work with stateful pointers only. Pushed a fix. |
Request does not work on stateful actor pointers.
c3a2947
to
fa3fd4b
Compare
📔 Description
This implements a command that dumps the known concepts without requiring the work to do a full status report.
📝 Checklist
🎯 Review Instructions
Commit-by-commit.