Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send correct message type when replacing partition #1200

Merged
merged 1 commit into from
Nov 26, 2020
Merged

Send correct message type when replacing partition #1200

merged 1 commit into from
Nov 26, 2020

Conversation

lava
Copy link
Member

@lava lava commented Nov 25, 2020 •
edited
Loading

📔 Description

📝 Checklist

  • All user-facing changes have changelog entries.
  • The changes are reflected on docs.tenzir.com/vast, if necessary.
  • The PR description contains instructions for the reviewer, if necessary.

🎯 Review Instructions

@mavam mavam added the bug Incorrect behavior label Nov 25, 2020
dominiklohmann
dominiklohmann approved these changes Nov 26, 2020
View reviewed changes
Copy link
Member

@dominiklohmann dominiklohmann left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code change itself is obviously fine modulo a proposed wording fix, but can you add a changelog entry for the fixed memory leak and also (edit: never released) append the changelog entry for the shrinking with this PRs number, because that did not work as expected either?

libvast/src/system/index.cpp Outdated Show resolved Hide resolved
@lava
Send correct message type when replacing partition
32b1169 
In addition to not shrinking the partitions in the meta
index (which would be relatively harmless), this also has
the nasty side effect of keeping a reference to the active
partition (as the sender of the message) alive, since the
index doesn't discard messages that it cannot process.
@lava lava merged commit f30ba65 into master Nov 26, 2020
@lava lava deleted the topic/vast-memory-leak branch November 26, 2020 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominiklohmann dominiklohmann dominiklohmann approved these changes

Assignees
No one assigned
Labels
bug Incorrect behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lava @dominiklohmann @mavam