Fix the bloom filter synopsis deserialization #1216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobim
force-pushed
the
story/ch21084/jemalloc-enable-profiling
branch
from
97fbe7a
to
3e8f66b
Compare
lava
force-pushed
the
story/ch21084/jemalloc-enable-profiling
branch
from
3e8f66b
to
b1fd3f5
Compare
tobim
force-pushed
the
story/ch21084/jemalloc-enable-profiling
branch
from
b1fd3f5
to
397c81a
Compare
mavam
reviewed
Dec 9, 2020
mavam
reviewed
Dec 9, 2020
tobim
changed the title
mavam
reviewed
Dec 10, 2020
tobim
force-pushed
the
story/ch21084/jemalloc-enable-profiling
branch
from
a28f068
to
12b87da
Compare
dominiklohmann
approved these changes
Dec 10, 2020
| @@ -73,7 +88,7 @@ class buffered_address_synopsis : public synopsis { | |||
| params.p = p_; | |||
| params.n = next_power_of_two; | |||
| VAST_DEBUG_ANON("shrinked address synopsis to", params.n, "elements"); | |||
| auto& type = this->type(); | |||
| auto type = detail::annotate_type(this->type(), params); | |||
There was a problem hiding this comment.
Please rename to annotated_type.
| @@ -73,7 +88,7 @@ class buffered_address_synopsis : public synopsis { | |||
| params.p = p_; | |||
| params.n = next_power_of_two; | |||
| VAST_DEBUG_ANON("shrinked address synopsis to", params.n, "elements"); | |||
There was a problem hiding this comment.
shrinked -> shrunk generally, and here to shrinks because it has yet to happen.
Move the `annotate_type()` helper function into a real namespace, since clang doesnt like functions in unnamed namespaces that are never called, emitting a warning that stops the build.
tobim
force-pushed
the
story/ch21084/jemalloc-enable-profiling
branch
from
12b87da
to
e596221
Compare
|
The CI on Mac fails with a known issue: https://app.clubhouse.io/tenzir/story/20882/race-condition-in-node-queries-unit-test As discussed offline, I'm merging this now and will include the final style changes in a follow-up PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📔 Description
📝 Checklist
🎯 Review Instructions