Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't collect status from sources and sinks #1234

Merged
merged 4 commits into from
Dec 15, 2020
Merged

Don't collect status from sources and sinks #1234

merged 4 commits into from
Dec 15, 2020

Conversation

tobim
Copy link
Member

@tobim tobim commented Dec 15, 2020 •
edited
Loading

📔 Description

Don't collect status messages from sources and sinks.

📝 Checklist

  • All user-facing changes have changelog entries.
  • The PR description contains instructions for the reviewer, if necessary.

🎯 Review Instructions

By commit.

@tobim tobim added maintenance Tasks for keeping up the infrastructure bug Incorrect behavior labels Dec 15, 2020
@tobim tobim requested a review from a team December 15, 2020 17:36
@tobim tobim changed the title Topic/disable sink source status Don't collect status from sources and sinks Dec 15, 2020
dominiklohmann
dominiklohmann approved these changes Dec 15, 2020
View reviewed changes
Copy link
Member

@dominiklohmann dominiklohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this locally and it works. Please add to the changelog entry that this was achieved by no longer querying sources and sinks for their status, and that we will re-enable this in the future once we figured out a proper fix to the issue.

@tobim tobim force-pushed the topic/disable-sink-source-status branch from 8ae8468 to 6342cac Compare December 15, 2020 19:18
dominiklohmann
dominiklohmann approved these changes Dec 15, 2020
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@tobim @dominiklohmann
Fix a typo in the changelog
a41ae7e 
Co-authored-by: Dominik Lohmann <mail@dominiklohmann.de>
@tobim tobim merged commit fa581c7 into master Dec 15, 2020
@tobim tobim deleted the topic/disable-sink-source-status branch December 15, 2020 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominiklohmann dominiklohmann dominiklohmann approved these changes

Assignees
No one assigned
Labels
bug Incorrect behavior maintenance Tasks for keeping up the infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tobim @dominiklohmann