Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove check whether config file is a regular file #1248

Merged
merged 2 commits into from
Dec 18, 2020

Conversation

dominiklohmann
Copy link
Member

@dominiklohmann dominiklohmann commented Dec 18, 2020

📔 Description

This removes the check whether a config file is a regular file.

This is unnecessary after 5b4b052, which I accidentally pushed to master directly. Sorry about that one. That commit made it so manually specified config files could be in the same directory as normal config files.

The changelog entry covers both changes.

📝 Checklist

  • All user-facing changes have changelog entries.
  • The changes are reflected on docs.tenzir.com/vast, if necessary.
  • The PR description contains instructions for the reviewer, if necessary.

🎯 Review Instructions

Look at this PR and the referenced commit.

This is unnecessary after 5b4b052, which I accidentally pushed to master
directly. Sorry about that one.
@dominiklohmann dominiklohmann added the bug Incorrect behavior label Dec 18, 2020
@dominiklohmann dominiklohmann requested a review from a team December 18, 2020 13:01
Copy link
Member

@lava lava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, except for the fact that the CHANGELOG says the opposite of what it should ;)

CHANGELOG.md Show resolved Hide resolved
@dominiklohmann dominiklohmann merged commit 38d68fb into master Dec 18, 2020
@dominiklohmann dominiklohmann deleted the topic/symlink-config-files branch December 18, 2020 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Incorrect behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants