Follow up for the CMake refactoring

[tobim]

📔 Description

• A few name changes weren't applied globally
• VAST_ENABLE_ASSERTIONS was broken.
• Unconditionally enable -Wundef
• Move defines back to config.hpp
• Synchonize definition names between CMake and C++

📝 Checklist

• All user-facing changes have changelog entries.
• The PR description contains instructions for the reviewer, if necessary.

🎯 Review Instructions

By commit.

[mavam]

The new CMake summary prints this:

-- The following features have been enabled:

 * VAST_ENABLE_RELOCATABLE_INSTALLATIONS, enable relocatable installations.
 * VAST_ENABLE_SDT, generate USDT tracepoint instrumentation.
 * VAST_ENABLE_ASSERTIONS, enable assertions.
 * BUILD_SHARED_LIBS, build shared instead of static library.
 * VAST_ENABLE_DEVELOPER_MODE, enables build settings for a nicer development environment.
 * VAST_ENABLE_BUNDLED_SCHEMAS, install bundled schemas with VAST.
 * VAST_ENABLE_ARROW, build with Apache Arrow support.
 * VAST_ENABLE_PCAP, build with PCAP support.
 * VAST_ENABLE_OPENSSL, encrypt network communication.
 * VAST_ENABLE_UNIT_TESTS, build unit tests for libvast.
 * VAST_ENABLE_VAST, build the standalone vast binary.

Why does BUILD_SHARED_LIBS have no VAST_ prefix?

[tobim]

@mavam that variable is defined by CMake itself, we just consider it important enough to include it in the summary.

[mavam]

The branch builds fine for me, and since CI is green, I think green-lighting this makes sense.

I do have a few questions though.

[mavam]

Can we remove this "noise" in the CMake run?

-- CREATING CAF TARGETS
-- Found CAF
-- Found CAF: /usr/local/lib/libcaf_core.dylib;/usr/local/lib/libcaf_io.dylib;/usr/local/lib/libcaf_openssl.dylib (found version "0.17.6") found components: openssl
-- CREATING CAF TARGETS

The all-caps comments probably don't need to be in here, right?

[mavam]

that variable is defined by CMake itself, we just consider it important enough to include it in the summary.

Maybe move it to the top/bottom then? Otherwise it looks like a bug.

[mavam]

After your latest commit, my only remaining concern would be the left-over TODO.