Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix potential race condition between evaluator and partition" #1381

Merged
merged 2 commits into from
Feb 17, 2021

Conversation

lava
Copy link
Member

@lava lava commented Feb 16, 2021

This reverts commit 3c93213.

We empirically verified that this fixes a segfault that can occur when running an export containing a partition that is ejected from the LRU cache while the export is going on, but I don't really understand the root cause so far :'(

📔 Description

📝 Checklist

  • All user-facing changes have changelog entries.
  • The changes are reflected on docs.tenzir.com/vast, if necessary.
  • The PR description contains instructions for the reviewer, if necessary.

🎯 Review Instructions

Copy link
Member

@tobim tobim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approved the original commit. I also wonder what is wrong with it, but getting the app to work again can come before the rest of the investigation.

@lava lava force-pushed the topic/revert-evaluator-ownership branch from b26c0f6 to b8d6e0c Compare February 17, 2021 08:41
@lava lava force-pushed the topic/revert-evaluator-ownership branch from b8d6e0c to 5e5d5fd Compare February 17, 2021 08:42
@lava lava merged commit db9e911 into master Feb 17, 2021
@lava lava deleted the topic/revert-evaluator-ownership branch February 17, 2021 09:46
@dominiklohmann dominiklohmann added the bug Incorrect behavior label Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Incorrect behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants