-
-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change the default batch size to 1024 #1396
Change the default batch size to 1024 #1396
Conversation
48ef89d
to
be8244a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this change makes any sense unless you also change vast.metrics.self-sink.slice-size
, which, as I've just noticed, always uses the default value, as libvast/src/accountant/config.cpp
has a spelling error in the key and writes slice
as slize
in two places.
be8244a
to
a12b510
Compare
I also changed the slice size of the accountant to a power of 2. |
2298bc7
to
1409ea8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, the only thing I noticed was a typo in the word "typo" in one of the commit messages :D (Fix a type in the accountant config
) But I think it's fine to just ignore this one.
1409ea8
to
a42df74
Compare
a42df74
to
622ec41
Compare
📔 Description
Since the default partitions size is a power of 2 it makes sense to do the same for the default batch size.
📝 Checklist