Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'mqtt' and 'anomaly' Suricata schema types #1408

Merged
merged 3 commits into from
Mar 2, 2021

Conversation

satta
Copy link
Contributor

@satta satta commented Mar 1, 2021

📔 Description

Adds schema support for the Suricata mqtt and anomaly event types.

📝 Checklist

  • All user-facing changes have changelog entries.
  • The PR description contains instructions for the reviewer, if necessary.

🎯 Review Instructions

Double-check format and formatting.

Copy link
Member

@dominiklohmann dominiklohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR! 🙏

I just have some minor change requests. Also, please run the integration tests with -u (e.g., sh path/to/build/integration_Debug.sh -u) to update the reference files, or update the reference file for the dump command manually.

CHANGELOG.md Outdated Show resolved Hide resolved
schema/types/suricata.schema Outdated Show resolved Hide resolved
schema/concepts/suricata.yaml Show resolved Hide resolved
@dominiklohmann
Copy link
Member

Merging despite the CI failure; it is unrelated to this PR.

@dominiklohmann dominiklohmann merged commit 19f8f25 into tenzir:master Mar 2, 2021
@satta satta deleted the mqtt-schema branch October 3, 2023 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants