Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate the vast.no-default-schema option #1409

Merged
merged 1 commit into from
Mar 2, 2021

Conversation

dominiklohmann
Copy link
Member

@dominiklohmann dominiklohmann commented Mar 2, 2021

📔 Description

The option is no longer needed since types can now be overridden in later schema directories.

📝 Checklist

  • All user-facing changes have changelog entries.
  • The changes are reflected on docs.tenzir.com/vast, if necessary.
  • The PR description contains instructions for the reviewer, if necessary.

🎯 Review Instructions

File-by-file.

@dominiklohmann dominiklohmann added the maintenance Tasks for keeping up the infrastructure label Mar 2, 2021
@dominiklohmann dominiklohmann requested a review from a team March 2, 2021 11:22
@dominiklohmann dominiklohmann force-pushed the story/ch23036/deprecate-no-default-schema branch from 4d033fc to 265aeff Compare March 2, 2021 11:24
@dominiklohmann dominiklohmann force-pushed the story/ch23036/deprecate-no-default-schema branch from 265aeff to bbeb0d5 Compare March 2, 2021 15:24
Copy link
Member

@tobim tobim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change is simple enough that I'm confident this is correct without testing locally.

@dominiklohmann dominiklohmann merged commit 8029b82 into master Mar 2, 2021
@dominiklohmann dominiklohmann deleted the story/ch23036/deprecate-no-default-schema branch March 2, 2021 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Tasks for keeping up the infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants