Prune expressions for the meta index lookup #1433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll review this one in practice, I still have a 1TB database with Zeek streaming JSON on my hard drive. |
There was a problem hiding this comment.
I verified the performance bump: I've seen a reduction from 2s to 0.4s on a similar query. There seems to be no visible performance penalty for regular queries.
I can reproduce the ASan failures in vast-test locally. Please fix and add a changelog entry, other than that LGTM.
tobim
force-pushed
the
story/ch23175/meta-index-redundancy
branch
from
750f8aa
to
890c6a7
Compare
|
I'm not sure whether I should add a changelog entry for this. |
|
@tobim if the performance gains are substantial, it's a nice change item. As a user, I always enjoy reading gains if they are specific and to the point (while broad claims are rather a turnoff). |
tobim
force-pushed
the
story/ch23175/meta-index-redundancy
branch
from
890c6a7
to
4c52e02
Compare
dominiklohmann
approved these changes
Mar 12, 2021
We can take advantage of the fact that all string fields are covered by the same type level synopsis. To be more specific: A query like `suricata.smb.host == "foo" || suricata.ssh.host == "foo"` would check whether the string "foo" is included the same type-level string synopsis twice. This commit adds a preprocessing step that removes predicates with duplicate strings from the expression as a preprocessing step for meta index lookups.
tobim
force-pushed
the
story/ch23175/meta-index-redundancy
branch
from
cf66ce4
to
a9e7364
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📔 Description
We can take advantage of the fact that all string fields are covered by the same type level synopsis. To be more specific: A query like
suricata.smb.host == "foo" || suricata.ssh.host == "foo"would check whether the string "foo" is included the same type-level string synopsis twice.This PR adds a preprocessing step that removes predicates with duplicate strings from the expression as a preprocessing step for meta index lookups.
In my local comparisons with 12723 partitions with
eve.logdata I get the a 4 times speedup for the queryvast export null 'net.domain == "alhgeoafh" || net.hostname == "alhgeoafh"'.A release build on master finishes the command in ~ 930 ms, this branch is done after ~ 240 ms.
📝 Checklist
🎯 Review Instructions
Try to reproduce my results.