Perform pass over build config defaults #695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominiklohmann
force-pushed
the
story/ch11536
branch
2 times, most recently
from
23163b4
to
b21e325
Compare
dominiklohmann
force-pushed
the
story/ch11536
branch
from
f3d0b00
to
b349623
Compare
tobim
requested changes
Jan 7, 2020
There was a problem hiding this comment.
When both REQUIRED and QUIET are present, QUIET takes precedence, overriding the REQUIRED flag.
This is not true, and the REQUIRED flag is needed in those places to retain our desired semantics.
We could think about removing the QUIET flag, which adds little value and hinders debugging.
dominiklohmann
force-pushed
the
story/ch11536
branch
from
b349623
to
f8f66c5
Compare
dominiklohmann
force-pushed
the
story/ch11536
branch
from
f8f66c5
to
96824ba
Compare
tobim
previously approved these changes
Jan 7, 2020
tobim
approved these changes
Jan 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.