-
-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor parser changes #706
Minor parser changes #706
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm reluctant to change the semantics of %
in this fashion, because we are using the parser also in other parts of the code where we do not want a trailing RHS. Instead, I suggest to explicitly identify the places where we want to allow trailing commas and change
x % y
to
(x % y) >> ~y
This way we retain maximum flexibility at the framework level.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks better now.
I think we want the same semantics for our data
parser, in particular for vector
, set
, and table
types.
No description provided.