Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor parser changes #706

Merged
merged 6 commits into from
Jan 13, 2020
Merged

Minor parser changes #706

merged 6 commits into from
Jan 13, 2020

Conversation

tobim
Copy link
Member

@tobim tobim commented Jan 10, 2020

No description provided.

@tobim tobim added the bug Incorrect behavior label Jan 10, 2020
@tobim tobim requested a review from a team January 10, 2020 15:42
@tobim tobim added maintenance Tasks for keeping up the infrastructure and removed bug Incorrect behavior labels Jan 10, 2020
Copy link
Member

@mavam mavam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm reluctant to change the semantics of % in this fashion, because we are using the parser also in other parts of the code where we do not want a trailing RHS. Instead, I suggest to explicitly identify the places where we want to allow trailing commas and change

x % y

to

(x % y) >> ~y

This way we retain maximum flexibility at the framework level.

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Member

@mavam mavam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks better now.

I think we want the same semantics for our data parser, in particular for vector, set, and table types.

CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@mavam mavam merged commit 2bf85d1 into master Jan 13, 2020
@mavam mavam deleted the story/ch11679 branch January 13, 2020 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Tasks for keeping up the infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants