Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize hash indexes to all data types #726

Merged
merged 4 commits into from
Jan 28, 2020
Merged

Generalize hash indexes to all data types #726

merged 4 commits into from
Jan 28, 2020

Conversation

mavam
Copy link
Member

@mavam mavam commented Jan 27, 2020

This makes it possible to use #index=hash on all data types.

@mavam mavam marked this pull request as ready for review January 27, 2020 15:53
@mavam mavam requested a review from tobim January 27, 2020 19:00
Copy link
Member

@tobim tobim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should have at least 2 more unit tests, maybe for address_type and vector_type. Sure these cases aren't very realistic, but the user interface supports them.

CHANGELOG.md Outdated Show resolved Hide resolved
@mavam
Copy link
Member Author

mavam commented Jan 28, 2020

I've added another unit for sets and merged the changelog entries.

Adding another unit test for set would not add much value in my opinion, as it would only test that the factory dispatches for that type to the hash index. Since hashing the views is orthogonal as well, I would argue we have good coverage for now.

@tobim tobim merged commit 9d1a8d2 into master Jan 28, 2020
@tobim tobim deleted the story/ch12322 branch January 28, 2020 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants