Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Continuous import of Zeek logs in VAST is broken #750

Merged
merged 3 commits into from
Feb 14, 2020
Merged

Continuous import of Zeek logs in VAST is broken #750

merged 3 commits into from
Feb 14, 2020

Conversation

tobim
Copy link
Member

@tobim tobim commented Feb 6, 2020

No description provided.

@tobim tobim added the bug Incorrect behavior label Feb 6, 2020
@lava lava force-pushed the story/ch11316 branch 2 times, most recently from bae5873 to 64e100f Compare February 12, 2020 12:59
@lava lava marked this pull request as ready for review February 12, 2020 13:01
tobim
tobim commented Feb 12, 2020
View reviewed changes
Copy link
Member Author

@tobim tobim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you got the interface for fdinbuf right, but i'd like to change line_range to make it more usable.

libvast/vast/detail/line_range.hpp Outdated Show resolved Hide resolved
libvast/src/detail/fdinbuf.cpp Outdated Show resolved Hide resolved
libvast/src/detail/line_range.cpp Outdated Show resolved Hide resolved
libvast/vast/detail/line_range.hpp Outdated Show resolved Hide resolved
libvast/src/detail/fdinbuf.cpp Outdated Show resolved Hide resolved
tobim
tobim commented Feb 13, 2020
View reviewed changes
libvast/test/format/zeek.cpp Show resolved Hide resolved
libvast/src/format/zeek.cpp Outdated Show resolved Hide resolved
libvast/src/format/zeek.cpp Show resolved Hide resolved
libvast/src/detail/line_range.cpp Outdated Show resolved Hide resolved
libvast/src/format/zeek.cpp Show resolved Hide resolved
@tobim
Copy link
Member Author

tobim commented Feb 13, 2020

BTW, this is looks almost finished to me.

dominiklohmann
dominiklohmann reviewed Feb 14, 2020
View reviewed changes
Copy link
Member

@dominiklohmann dominiklohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good. The feedback by @tobim needs to be addressed, though.

@lava
Fix stalling bug in zeek continous import
0a2d0e1 
The zeek reader would always try to read up to slice_size events from
the input stream. For a continous stream that did not have that many
events, the reader would block indefinitely until either more events
arrive or the stream was closed.
dominiklohmann
dominiklohmann approved these changes Feb 14, 2020
View reviewed changes
Copy link
Member

@dominiklohmann dominiklohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@lava lava merged commit 28725db into master Feb 14, 2020
@lava lava deleted the story/ch11316 branch February 14, 2020 15:33
@mavam
Copy link
Member

mavam commented Feb 14, 2020

It feels like a changelog entry should document the bugfix.

@dominiklohmann dominiklohmann mentioned this pull request Apr 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lava lava lava left review comments

@mavam mavam mavam left review comments

@dominiklohmann dominiklohmann dominiklohmann approved these changes

Assignees
No one assigned
Labels
bug Incorrect behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tobim @mavam @lava @dominiklohmann