-
-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement reader for Syslog RFC5424 #770
Implement reader for Syslog RFC5424 #770
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! 🚀
Can you do a first pass of rebasing? Ideally, this would be just five commits:
- Add Syslog parser (RFC5424)
- Add unit tests for Syslog parser
- Add reader for Syslog
- Hook reader into command line
- Add integration tests for real-world Syslog data
Additionally, please do a pass over your code after reading our contributing guide.
Other than that, this is looking quite good already. I'll do a second pass tomorrow that's more code-specific.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've done a second pass.
cf1130d
to
5ad8c99
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have done another pass.
a7f6dcc
to
f0d8911
Compare
@knapperzbusch should this still be in draft mode? |
I will do rebase with master today night or tomorrow morning, to resolve the conflicts. |
Sounds good. Will do one last review pass then (likely next week), so we can get this merged. |
91a7cd8
to
680e288
Compare
680e288
to
da60505
Compare
I took the freedom to rebase this once more and rewrite some comments—no more code changes were necessary. Thanks for your contribution, @knapperzbusch! We'll merge once CI has run through successfully. |
da60505
to
0e17d84
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! 🚀
This PR adds a Syslog parser and reader. With this, it is possible to import Syslog messages in the format defined in RFC5424. If a message can't be parsed, the message will be handled as single string.