Restrict log file creation to 'vast start' #803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lava
commented
Mar 24, 2020
Yes, by design: The overall goal was that commands issued by the user in his terminal should not pollute the current working directory by creating a vast log directory, which would include |
Yes, since it is basically running |
lava
force-pushed
the
story/ch13090
branch
2 times, most recently
from
4b26fe5
to
35ad34a
Compare
dominiklohmann
requested changes
Mar 24, 2020
|
I added a commit addressing ch13324 into this PR as well, since both stories are closely related to the logging behaviour of caf and touch the same code anyways. |
Set file verbosity to 'quiet' by default, and do not create a log file and log directory when file verbosity is set to 'quiet'. Set file verbosity to 'debug' by default only for the 'vast start' subcommand.
The config options 'vast.log-directory' was deprecated and replaced by 'vast.log-file'. If specified, all log files will be written to the specified file.
dominiklohmann
approved these changes
Mar 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set file verbosity to 'quiet' by default, and do not create a log file and log directory when file verbosity is set to 'quiet'.
Set file verbosity to 'debug' by default only for the 'vast start' subcommand.