-
-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use line reader timeout #835
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good modulo the change requested by @tobim .
Should we maybe do the same change for all readers now, to avoid users running into them one-by-one?
@tenzir/backend I've adapted this PR to fix the issue for CSV and Syslog as well. Please re-review. Still running some tests locally to verify the issue is fixed for the other formats as well. |
b3b29a9
to
a40198a
Compare
6dfb87b
to
fe81901
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, although I still think we should have a warning about the "Thou shalt not return 0" bug in a comment somewhere.
daadef7
to
f59f0ce
Compare
@lava see also: |
2810ae6
to
32a4258
Compare
This fixes a bug that caused continuous Suricata imports to possibly hang.