Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deduce types for heterogenous JSONL import #875

Merged
merged 15 commits into from
May 26, 2020
Merged

Deduce types for heterogenous JSONL import #875

merged 15 commits into from
May 26, 2020

Conversation

dominiklohmann
Copy link
Member

No description provided.

@dominiklohmann dominiklohmann added the feature New functionality label May 18, 2020
mavam
mavam reviewed May 18, 2020
View reviewed changes
libvast/vast/format/json.hpp Outdated Show resolved Hide resolved
@dominiklohmann dominiklohmann force-pushed the story/ch16785 branch 3 times, most recently from a2e964c to 8f4ac4e Compare May 18, 2020 15:06
@dominiklohmann dominiklohmann force-pushed the story/ch16785 branch 11 times, most recently from a261e9f to 04423ed Compare May 25, 2020 10:16
@dominiklohmann dominiklohmann marked this pull request as ready for review May 25, 2020 10:16
@dominiklohmann dominiklohmann requested a review from mavam May 25, 2020 10:16
mavam
mavam requested changes May 25, 2020
View reviewed changes
Copy link
Member

@mavam mavam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Just some small stuff in my feedback.

CHANGELOG.md Outdated Show resolved Hide resolved
libvast/src/system/type_registry.cpp Outdated Show resolved Hide resolved
libvast/src/system/type_registry.cpp Show resolved Hide resolved
libvast/vast/system/import_command.hpp Show resolved Hide resolved
libvast/vast/system/import_command.hpp Outdated Show resolved Hide resolved
libvast/vast/system/source.hpp Outdated Show resolved Hide resolved
libvast/vast/system/source.hpp Outdated Show resolved Hide resolved
libvast/vast/json.hpp Outdated Show resolved Hide resolved
libvast/vast/format/json.hpp Show resolved Hide resolved
libvast/vast/format/json.hpp Outdated Show resolved Hide resolved
@dominiklohmann dominiklohmann force-pushed the story/ch16785 branch 2 times, most recently from e6c25f0 to 4959a84 Compare May 26, 2020 09:14
@dominiklohmann dominiklohmann requested a review from mavam May 26, 2020 09:17
mavam
mavam requested changes May 26, 2020
View reviewed changes
libvast/src/system/type_registry.cpp Outdated Show resolved Hide resolved
libvast/vast/system/import_command.hpp Outdated Show resolved Hide resolved
libvast/vast/system/import_command.hpp Outdated Show resolved Hide resolved
libvast/vast/system/import_command.hpp Show resolved Hide resolved
libvast/vast/system/source.hpp Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
libvast/vast/format/json.hpp Outdated Show resolved Hide resolved
@dominiklohmann dominiklohmann requested a review from mavam May 26, 2020 12:35
@dominiklohmann dominiklohmann force-pushed the story/ch16785 branch 2 times, most recently from 4847299 to 1e0837d Compare May 26, 2020 12:42
mavam
mavam reviewed May 26, 2020
View reviewed changes
libvast/vast/format/json.hpp Outdated Show resolved Hide resolved
@dominiklohmann dominiklohmann requested a review from mavam May 26, 2020 13:21
mavam
mavam approved these changes May 26, 2020
View reviewed changes
Copy link
Member

@mavam mavam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! 👍

@dominiklohmann dominiklohmann merged commit 264eab6 into master May 26, 2020
@dominiklohmann dominiklohmann deleted the story/ch16785 branch May 26, 2020 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lava lava lava left review comments

@mavam mavam mavam approved these changes

Assignees
No one assigned
Labels
feature New functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dominiklohmann @lava @mavam