Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add '--by' option to 'vast explore' #877

Merged
merged 5 commits into from
May 20, 2020
Merged

Add '--by' option to 'vast explore' #877

merged 5 commits into from
May 20, 2020

Conversation

lava
Copy link
Member

@lava lava commented May 19, 2020

No description provided.

@lava lava requested a review from dominiklohmann May 19, 2020 10:08
dominiklohmann
dominiklohmann requested changes May 19, 2020
View reviewed changes
Copy link
Member

@dominiklohmann dominiklohmann left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor style things and the usual request for a changelog entry (you can also adapt the previous one).

Obviously the failing integration test must be addressed as well.

libvast/src/system/application.cpp Outdated Show resolved Hide resolved
libvast/src/system/explorer.cpp Outdated Show resolved Hide resolved
libvast/src/system/explorer.cpp Outdated Show resolved Hide resolved
libvast/src/system/spawn_explorer.cpp Outdated Show resolved Hide resolved
libvast/src/system/spawn_explorer.cpp Show resolved Hide resolved
libvast/test/system/explorer.cpp Outdated Show resolved Hide resolved
libvast/test/system/explorer.cpp Outdated Show resolved Hide resolved
libvast/test/system/explorer.cpp Outdated Show resolved Hide resolved
libvast/test/system/explorer.cpp Outdated Show resolved Hide resolved
libvast/test/system/explorer.cpp Outdated Show resolved Hide resolved
@dominiklohmann dominiklohmann added the feature New functionality label May 19, 2020
@lava lava force-pushed the story/ch16867 branch 2 times, most recently from b4ff09f to 6c8788c Compare May 19, 2020 13:11
@lava lava requested a review from dominiklohmann May 19, 2020 14:49
dominiklohmann
dominiklohmann approved these changes May 20, 2020
View reviewed changes
Copy link
Member

@dominiklohmann dominiklohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good to me, just have a slight nit.

libvast/src/system/spawn_explorer.cpp Show resolved Hide resolved
@lava lava merged commit e34e6c4 into master May 20, 2020
@lava lava deleted the story/ch16867 branch May 20, 2020 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mavam mavam mavam left review comments

@dominiklohmann dominiklohmann dominiklohmann approved these changes

Assignees
No one assigned
Labels
feature New functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lava @mavam @dominiklohmann