Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display Hasse diagram for the Subgraph #305

Merged
merged 4 commits into from
Oct 6, 2024

Conversation

vlad902
Copy link
Contributor

@vlad902 vlad902 commented Oct 5, 2024

Also update the script to generate such graphs.

Closes #183

@vlad902
Copy link
Contributor Author

vlad902 commented Oct 5, 2024

I forgot to update the blueprint, will do that now.

@vlad902 vlad902 marked this pull request as draft October 5, 2024 08:08
@vlad902 vlad902 marked this pull request as ready for review October 5, 2024 08:22
@pitmonticone
Copy link
Collaborator

Thanks a lot, @vlad902!

leanblueprint pdf returns an error regarding the image we're including.

Please consider running the executable script scripts/run_before_push.sh to avoid this risk.

@vlad902
Copy link
Contributor Author

vlad902 commented Oct 6, 2024

Ah, of course. It builds successfully locally, because I have the PNG, but it fails in CI, because I forgot to git add it.

@teorth teorth merged commit 46a3207 into teorth:main Oct 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants