Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logic issue with linking storages to captures #58

Open
Nefarious46 opened this issue Mar 24, 2024 · 2 comments
Open

Logic issue with linking storages to captures #58

Nefarious46 opened this issue Mar 24, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@Nefarious46
Copy link
Contributor

Description
While writing apidoc an issue was discovered with linking flow storages to captures where wrong ID was used when linking flow storages to captures. This allows linking multiples of the same flow storage BUT with different FLOW.

Should be refactored to only allow linking captures to flow storage with the same FLOW. This should also return error to end user.

@Nefarious46 Nefarious46 added the bug Something isn't working label Mar 24, 2024
@Nefarious46 Nefarious46 self-assigned this Mar 24, 2024
@Nefarious46
Copy link
Contributor Author

Manual testing

one storage with ID = 1

two flows "a" and "b"

two different sinks for 2 different captures with flows "a" and "b"

two captures with ID of 1 and 2

Captures. Same everything but different flow_id
1,1,1,1,1,1,1,relp,1,1,1
2,1,1,1,1,1,1,relp,2,1,2

Flow_targets. Different flow_id but same storage_id
1,1,1,cfe_04
2,2,1,cfe_04

capture_storages. capture_id, flow_id and flow_target_id.
1,1,1,1
2,2,2,1

Conclusion = No constraint errors. Just misleading column name. Change column name to storage_id.

@Nefarious46
Copy link
Contributor Author

Awaits changes from cfe_31 that properly link storages per capture.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant