Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Config.java immutable #36

Open
Tiihott opened this issue Aug 19, 2024 · 1 comment
Open

Make Config.java immutable #36

Tiihott opened this issue Aug 19, 2024 · 1 comment
Assignees
@Tiihott
Labels
review

Comments

@Tiihott
Copy link

Tiihott commented Aug 19, 2024

Description
Config.java is using setter for changing hdfsuri parameter for tests that are using hdfs minicluster. Make changes to the code so instead of setter the hdfsuri parameter can be defined using a secondary constructor, which in turn allows the Config objects to be immutable.
@Tiihott Tiihott self-assigned this Aug 19, 2024
@Tiihott
Copy link
Author

Tiihott commented Sep 12, 2024

Solved in beta branch PR #41 alongside issue #44

@Tiihott Tiihott added the review label Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tiihott Tiihott

Labels
review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Tiihott