Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

timechart doesn't throw an exception with invalid input #27

Open
51-code opened this issue Mar 20, 2024 · 0 comments
Open

timechart doesn't throw an exception with invalid input #27

51-code opened this issue Mar 20, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@51-code
Copy link
Contributor

51-code commented Mar 20, 2024

Describe the bug

The following query doesn't throw an exception:
index=xyz | timechart count test1 test2 test3 123
Same happens when using the BY clause and then typing invalid input afterwards.

Good thing is that this doesn't really break the execution of the commands before the invalid input. The query is executed properly, it just ignores the invalid input.
If any other commands or parameters are written after the invalid input, they are also ignored.

Expected behavior

Should throw an error when encountering invalid input.
In the example "test1" is the first invalid word.

How to reproduce

Run the query.

Screenshots

Software version

PTH-03: 5.4.0

Desktop (please complete the following information if relevant):

  • OS:
  • Browser:
  • Version:

Additional context

The lexer properly classifies the found tokens.
The parser stops building the parse tree when it encounters the first piece of invalid input, but it doesn't throw an error.

@51-code 51-code added the bug Something isn't working label Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant