Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setfields command doesn't parse additional setfieldsParameters #45

Open
51-code opened this issue Jul 30, 2024 · 0 comments
Open

Setfields command doesn't parse additional setfieldsParameters #45

51-code opened this issue Jul 30, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@51-code
Copy link
Contributor

51-code commented Jul 30, 2024

Describe the bug

There is a test case like this:
| setfields test="testtestest", fuu="fuu byr"
it doesn't parse the part after the comma and it gives an error:

line 46:32 mismatched input 'fuu' expecting {PIPE, COMMA}

When looking at the parse tree made from this query, it can be seen that the comma in between two setfieldsParameters is included in the "testtesttest", string. For adding multiple setfieldsParameters, the grammar requires a comma in between, which now there isn't. The parsing is stopped, and only one setFieldsParameter is therefore parsed.

Expected behavior

Should parse multiple setFieldsParameters.

How to reproduce

Test the query above.

Screenshots

Software version

6.1.0

Desktop (please complete the following information if relevant):

  • OS:
  • Browser:
  • Version:

Additional context

Comma isn't an allowed character in a String in setfields, so it is weird that it is parsed as a part of the StringType. More investigation needed for finding the exact culprit of the issue.

setfieldsSyntaxParseTest in SetfieldsSyntaxTests.java has been disabled because of this issue in PR #52.

@51-code 51-code added the bug Something isn't working label Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant