Sort grammar rewrite and bugfix with multiple fields #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eemhu
reviewed
Aug 12, 2024
kortemik
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #49 and #64 .
Rewrote sort command's grammar to allow multiple fields with a comma delimiter.
Grammar was refactored because it didn't support having the optional parameters anywhere in the query. So, the main change is the main grammar rule in sort which now allows having the parameters in any order and as many times as wanted. Now it is more or less left for PTH-10 to check that the parameters are given just once etc.
Added a new grammar rule for the plus sign: differentiated it from the minus for easier visiting in PTH-10.
Wrote unit tests for sort command, there weren't any before.