Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] 5xx error on not existent container or version #150

Closed
teran opened this issue Aug 17, 2024 · 0 comments · Fixed by #161
Closed

[BUG] 5xx error on not existent container or version #150

teran opened this issue Aug 17, 2024 · 0 comments · Fixed by #161
Assignees
@71g3pf4c3
Labels
archived-publisher publisher related tasks bug Something isn't working good first issue Good for newcomers
Milestone
v0.0.8

Comments

@teran
Copy link
Owner

teran commented Aug 17, 2024 •
edited
Loading

Describe the bug
5xx error is displayed by publisher on accessing not existent container or version

To Reproduce
Steps to reproduce the behavior:

  1. go generate -v ./... && goreleaser build --snapshot --clean && docker-compose build && docker-compose up || docker-compose down
  2. access via browser to any (not existent) container
  3. create new container via archived-cli
  4. access via browser to any (not existent) version

Expected behavior
Not existent entities must report 404 error

Configuration file snippet

doesn't matter, since reproduced right with instruction in README

Additional context
n/a
@teran teran added archived-publisher publisher related tasks bug Something isn't working good first issue Good for newcomers labels Aug 17, 2024
@teran teran added this to the v0.0.8 milestone Aug 17, 2024
@teran teran added this to archived Aug 17, 2024
@teran teran moved this to Ready in archived Aug 17, 2024
@teran teran changed the title [BUG] 5xx error on not existent container [BUG] 5xx error on not existent container or version Aug 17, 2024
@71g3pf4c3 71g3pf4c3 self-assigned this Aug 18, 2024
@teran teran moved this from Ready to In progress in archived Aug 18, 2024
@teran teran mentioned this issue Aug 18, 2024
Merged
@teran teran linked a pull request Aug 20, 2024 that will close this issue
Fix service error mapping on listing nonexistent container #161
Merged
@teran teran closed this as completed in #161 Sep 1, 2024
@github-project-automation github-project-automation bot moved this from In progress to Done in archived Sep 1, 2024
@teran teran mentioned this issue Sep 1, 2024
Merged
teran added a commit that referenced this issue Sep 1, 2024
@teran
Fix missed error mapping on service side when version doesn't exist (#…
432fc8e 
…197)

Related #150

Signed-off-by: Igor Shishkin <me@teran.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@71g3pf4c3 71g3pf4c3

Labels
archived-publisher publisher related tasks bug Something isn't working good first issue Good for newcomers
Projects
archived
Status: Done
Milestone
v0.0.8
2 participants
@teran @71g3pf4c3