Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

teraslice external modules #3649

Open
jsnoble opened this issue Jun 12, 2024 · 0 comments
Open

teraslice external modules #3649

jsnoble opened this issue Jun 12, 2024 · 0 comments

Comments

@jsnoble
Copy link
Member

jsnoble commented Jun 12, 2024

  • typically we put our approved helper functions and libraries come out of our utils library. We have several exported function from lodash here that we allow. However in teraslice we directly import lodash into use but they should live in utils if they are universal (which several of them are). Some of these helper function are not needed since we now have more modern tools like Object.entries and the like. We should consolidate the functions we need from teraslice into utils. Many of these functions also live in the k8s code section so we need to tests there
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant