-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Package request: node-sass #1001
Comments
Hi @Rudloff @fornwall, the issue why node-sass doesn't build on android is related to: #307 -> the compiler option in node-gyp / common.gypi is still fPIE (nodejs/node@271201f) and that produces a segfault. In order for build on android, node-sass needs to be compiled with fPIC. I'm currently trying to see if I can follow the instructions here to provide a build for android. |
Just hit this issue, if a fix is coming - fantastic! |
@andrewcharnley : I cannot promise how fast I can be. Therefore, the fastest solution is to build node-sass yourself on android. Just follow the instructions I outlined here: http://blog.akehir.com/2017/05/building-node-sass-libsass-python.html |
Followed that and it builds now, however upon usage I have the same message:- android-arm-48/binding.node has text relocations.... segmentation fault |
Hi @andrewcharnley : This indicates the flags have not been set correctly. What's your node --version? I just followed the process, and currently it is 6.11.0 -> then the common.gypi in that specific directory needs to be edited (ie. nano ~/.node-gyp/6.11.0/include/node/common.gypi ). If you edited the old 6.10.3 node directory, but did upgrade packages to install 6.11.0, then it won't work. Furthermore, there are 2 configs in common.gypi: Debug, and Release. You need to edit both (or, at least the Release config, which is further down in the file) to use -fPIC as compiler option. Once you've done that you can npm rebuild node-sass -f |
I didn't look at common.gypi correctly and only edited the debug config. Working fine now. :) |
I tried following same tutorial but there is not common.gypi file available anywhere, any ideas?? |
The file should be generated when you first try 'npm install node-sass'. It's located in your application user's home directory ( Then, in your home directory, the ' In any case, with node 6.11.3, the common.gypi would be under: |
Thanks, I switched to ruby sass compiler temporarily, now I can switch back to node. |
Amazing, would love to see it working. Will check out the guide on building it. |
on android 7.1.2 cyanogenmod work fine. edit: I got some erros.. But I recommend using the stylus and stylus-loader it is very similar to sass and I recommend it by |
Any updates? |
Move node sass to stylus not a solution |
ive tried following the steps above and in the linked blog, node sass installs succesfully but during build i get this error |
same thing here. |
Many upstream frameworks have moved to |
Upstream refuses to support Android (sass/node-sass#1944) but maybe it can be patched on our end.
The text was updated successfully, but these errors were encountered: