fix: Update module dependencies for TF 0.14 support #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emedvedev
changed the title
bryantbiggs
approved these changes
Dec 20, 2020
There was a problem hiding this comment.
@antonbabenko this is ready to merge - validated with complete example using master and then updated source to this change set. the only thing to note is that it looks like the security groups Name is wanting to update:
~ tags = {
"Environment" = "dev"
~ "Name" = "atlantiscomplete-alb-https" -> "atlantiscomplete"
"Owner" = "user"
}
|
Thanks @bryantbiggs for the review! v2.28.0 has been just released. |
|
Thank you! |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates module dependencies to provide support for Terraform 0.14.
Motivation and Context
The versions of module dependencies that are used now set the
required_versionparameter as< 0.14.0, which means we cannot use the module with Terraform 0.14.Breaking Changes
Does not break compatibility: the new versions are all backwards-compatible.
How Has This Been Tested?
Tested with
terraform validateon Terraform 0.14.