feat: Allow unauthenticated access for webhooks to /events endpoint if needed #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exception for the webhook endpoint Fixes terraform-aws-modules#223
gozer
changed the title
antonbabenko
changed the title
|
But if IP CIDRs are provided, isn't this unnecessary? Or even worse, this weakens the security and make the CIDR based rule almost pointless? Should this only be added when there is no CIDRs present? |
snovikov
added a commit
to Flaconi/terraform-aws-atlantis
that referenced
this pull request
Oct 7, 2021
* feat: Add sensitive flag for webhook secret outputs (terraform-aws-modules#222) * Updated CHANGELOG * fix: Add missing netblock (143.55.64.0/20) to GitHub webhook IP ranges (terraform-aws-modules#225) * feat: Allow unauthenticated access for webhooks to /events endpoint if needed (terraform-aws-modules#226) * Updated CHANGELOG Co-authored-by: Anton Babenko <anton@antonbabenko.com> Co-authored-by: Philippe M. Chiasson <gozer@ectoplasm.org>
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
exception for the webhook endpoint
Fixes #223
Description
Motivation and Context
Breaking Changes
How Has This Been Tested?
examples/*projects