feat: add tags support to root block device

[achachw]

Description

Adding tag support to root block device

Motivation and Context

Actually, all of these parameters are supported for root_block_device block : volume_size, volume_type, iops, .. except tags.
I would suggest to add tags.

Breaking Changes

How Has This Been Tested?

• I have tested and validated these changes using one or more of the provided examples/* projects

[antonbabenko]

Hi,

tags became available in 3.24.0 - https://github.com/hashicorp/terraform-provider-aws/blob/main/CHANGELOG.md#3240-january-14-2021

Please upgrade versions.tf accordingly.

[achachw]

Hi @antonbabenko
Thanks for your quick reply.

[antonbabenko]

v2.18.0 has been just released.

[jinglejengel]

FYI this appears to have broken the module.

When trying both no tags in the root_block_device and passing in a map of strings to a tag field in the root_block_device I receive the same error:

Error: Incorrect attribute value type

  on .terraform/modules/ec2/main.tf line 38, in resource "aws_instance" "this":
  38:       tags                  = lookup(root_block_device.value, "tags", null)

Inappropriate value for attribute "tags": map of string required.

[antonbabenko]

Too bad that I trusted this PR without actually doing the normal procedure. Fixed in #220.

Please update to use v2.19.0 that has been just released.

[jinglejengel]

Thanks for super quick turnaround @antonbabenko!

[yatryan]

Unfortunately, this update was a breaking change for a number of my projects. Bumping up hashicorp/aws from ">= 2.65" to ">= 3.24" caused some incompatibilities. Any reason this wasn't a breaking change version bump?

[achachw]

Ah sorry for this miss .. guys.

[grig-tar]

One more issue here - tags were added to 'root_block_device' only but forgotten about 'ebs_block_device'.

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.