-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for autoscaling group AMI override #1498
Comments
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue has been resolved in version 18.0.0 🎉 |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Is your request related to a new offering from AWS?
https://docs.aws.amazon.com/autoscaling/ec2/userguide/asg-launch-template-overrides.html
Is your request related to a problem? Please describe.
Since aws has introduced eks support for arm instances the module should also support the creation of asg with mixed instance type (arm64, x64).
The suggested way to implement this feature is to create multiple
launchtemplates
and overriding the default launch template with a specific one related to the instance type.Describe the solution you'd like.
The module should provide a way to override the
launchtemplate
inside themixed_instances_policy
ofaws_autoscaling_group
as defined in the aws examples.At the moment the feature is only supported for the
instance_type
by providing theoverride_instance_types
variable:terraform-aws-eks/workers_launch_template.tf
Lines 159 to 169 in 9022013
The module should also define
launch_template_specification
if neededWe can introduce a new parameter such as
override_instance_type_launch_template
that allow users to provideinstance_type
tolaunch_template_id
association.The text was updated successfully, but these errors were encountered: