Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for autoscaling group AMI override #1498

Closed
GaruGaru opened this issue Jul 23, 2021 · 3 comments · Fixed by #1680
Closed

Support for autoscaling group AMI override #1498

GaruGaru opened this issue Jul 23, 2021 · 3 comments · Fixed by #1680

Comments

@GaruGaru
Copy link

GaruGaru commented Jul 23, 2021

Is your request related to a new offering from AWS?

https://docs.aws.amazon.com/autoscaling/ec2/userguide/asg-launch-template-overrides.html

Is your request related to a problem? Please describe.

Since aws has introduced eks support for arm instances the module should also support the creation of asg with mixed instance type (arm64, x64).

The suggested way to implement this feature is to create multiple launchtemplates and overriding the default launch template with a specific one related to the instance type.

Describe the solution you'd like.

The module should provide a way to override the launchtemplate inside the mixed_instances_policy of aws_autoscaling_group as defined in the aws examples.

At the moment the feature is only supported for the instance_type by providing the override_instance_types variable:

dynamic "override" {
for_each = lookup(
var.worker_groups_launch_template[count.index],
"override_instance_types",
local.workers_group_defaults["override_instance_types"]
)
content {
instance_type = override.value
}
}

The module should also define launch_template_specification if needed

      override {
        instance_type = override.value
        launch_template_specification {
          launch_template_id = <instance_launch_template_id>
        } 
      }

We can introduce a new parameter such as override_instance_type_launch_template that allow users to provide instance_type to launch_template_id association.

@GaruGaru GaruGaru changed the title Support for launch templates override in worker_groups_launch_template Support for autoscaling group AMI override Jul 27, 2021
@stale
Copy link

stale bot commented Oct 2, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@antonbabenko
Copy link
Member

This issue has been resolved in version 18.0.0 🎉

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.