Drop support for aws_launch_configuration

[bryantbiggs]

Is your request related to a new offering from AWS?

• No, but yes - https://aws.amazon.com/blogs/compute/amazon-ec2-auto-scaling-will-no-longer-add-support-for-new-ec2-features-to-launch-configurations/

Is your request related to a problem? Please describe.

• Maintainability

Describe the solution you'd like.

• As part of the next breaking change, remove support for aws_launch_configuration and simplify the module by relying on just aws_launch_template

Describe alternatives you've considered.

• None

Additional context

Because AWS is not adding any new features, and LT has long superseded LC, I think this will greatly help in simplifying a lot of complexity and duplication within the module

[bryantbiggs]

@daroga0002 / @antonbabenko - happy to hear your thoughts

[antonbabenko]

I agree, and it's a good idea to include it in v18.0.0 if possible.

[bryantbiggs]

I started on a PR last night and will keep working on it - removing launch configuration, converting from count to for_each, etc. Its still early but I'll keep working on it over today and tomorrow, stay tuned #1680

[daroga0002]

happy to hear your thoughts

Yup, I think it is without sense to hold launch configurations as launch templates are for long time and we have node groups

[antonbabenko]

This issue has been resolved in version 18.0.0 🎉

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.