Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update preset rule on semantic-release to use conventional commits #1736

Merged
merged 2 commits into from
Jan 5, 2022

Conversation

bryantbiggs
Copy link
Member

Description

  • update preset rule on semantic-release to use conventional commits

Note: this should re-scan the commit since the last release and pick up the breaking feat! change causing v18.x to be released

Motivation and Context

  • current release process is not triggering a breaking change release due to using default angular preset

Breaking Changes

  • no

How Has This Been Tested?

@bryantbiggs bryantbiggs changed the title fix: update preset rule on semantic-release to use conventional commits fix: Update preset rule on semantic-release to use conventional commits Jan 5, 2022
@antonbabenko antonbabenko merged commit be86c0b into terraform-aws-modules:master Jan 5, 2022
antonbabenko pushed a commit that referenced this pull request Jan 5, 2022
## [18.0.0](v17.24.0...v18.0.0) (2022-01-05)

### ⚠ BREAKING CHANGES

* Removed support for launch configuration and replace `count` with `for_each` (#1680)

### Features

* Removed support for launch configuration and replace `count` with `for_each` ([#1680](#1680)) ([ee9f0c6](ee9f0c6))

### Bug Fixes

* Update preset rule on semantic-release to use conventional commits ([#1736](#1736)) ([be86c0b](be86c0b))
@antonbabenko
Copy link
Member

This PR is included in version 18.0.0 🎉

@antonbabenko
Copy link
Member

Fantastic! It is so magical but it works when it works! Thanks for this fix. 👍

@bryantbiggs bryantbiggs deleted the fix/release branch January 6, 2022 12:40
baibailiha added a commit to baibailiha/terraform-aws-eks that referenced this pull request Sep 13, 2022
## [18.0.0](terraform-aws-modules/terraform-aws-eks@v17.24.0...v18.0.0) (2022-01-05)

### ⚠ BREAKING CHANGES

* Removed support for launch configuration and replace `count` with `for_each` (#1680)

### Features

* Removed support for launch configuration and replace `count` with `for_each` ([#1680](terraform-aws-modules/terraform-aws-eks#1680)) ([17031bd](terraform-aws-modules/terraform-aws-eks@17031bd))

### Bug Fixes

* Update preset rule on semantic-release to use conventional commits ([#1736](terraform-aws-modules/terraform-aws-eks#1736)) ([e26a7d9](terraform-aws-modules/terraform-aws-eks@e26a7d9))
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants