Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Change variable "node_security_group_additional_rules" from type map(any) to any #1747

Conversation

pjrm
Copy link
Contributor

@pjrm pjrm commented Jan 6, 2022

Description

When trying to specify different types of security groups maps, the merge fail because the map is different. Example:

    # Override the default security groups, if web-proxy is enabled
    egress_8080 = {
      description = "First securit ygroup"
      protocol    = "tcp"
      from_port   = 8080
      to_port     = 8080
      type        = "egress"
      cidr_blocks = ["0.0.0.0/0"]
    }
    ingress_cluster_9443 = {
      description                   = "Another security group"
      protocol                      = "tcp"
      from_port                     = 9443
      to_port                       = 9443
      type                          = "ingress"
      source_cluster_security_group = true
    }
  }

This throws an error:
The given value is not suitable for child module variable "node_security_group_additional_rules" defined at .terraform/modules/eks.eks/variables.tf:200,1-48: all map elements must have the same type.

If the variable type is any, the issue no longer exists because the merge occurs without a problem.

Copy link
Member

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@antonbabenko 👍🏽

thanks for the fix @pjrm 🎉

@antonbabenko antonbabenko merged commit 8921827 into terraform-aws-modules:master Jan 6, 2022
antonbabenko pushed a commit that referenced this pull request Jan 6, 2022
### [18.0.2](v18.0.1...v18.0.2) (2022-01-06)

### Bug Fixes

* Change variable "node_security_group_additional_rules" from type map(any) to any ([#1747](#1747)) ([8921827](8921827))
@antonbabenko
Copy link
Member

This PR is included in version 18.0.2 🎉

@pjrm pjrm deleted the fix_node_security_group_additional_rules branch January 6, 2022 21:50
baibailiha added a commit to baibailiha/terraform-aws-eks that referenced this pull request Sep 13, 2022
### [18.0.2](terraform-aws-modules/terraform-aws-eks@v18.0.1...v18.0.2) (2022-01-06)

### Bug Fixes

* Change variable "node_security_group_additional_rules" from type map(any) to any ([#1747](terraform-aws-modules/terraform-aws-eks#1747)) ([b87a1c5](terraform-aws-modules/terraform-aws-eks@b87a1c5))
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants