Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Correct remote access variable for security groups and add example for additional IAM policies #1766

Merged

Conversation

bryantbiggs
Copy link
Member

@bryantbiggs bryantbiggs commented Jan 11, 2022

Description

Motivation and Context

Breaking Changes

  • No

How Has This Been Tested?

  • I have tested and validated these changes using one or more of the provided examples/* projects
    • Validate with eks-managed-node-group example

@bryantbiggs bryantbiggs changed the title fix: correct remote access variable for security groups and add example for additional IAM policies fix: Correct remote access variable for security groups and add example for additional IAM policies Jan 11, 2022
@bryantbiggs bryantbiggs marked this pull request as ready for review January 11, 2022 18:39
@bryantbiggs bryantbiggs marked this pull request as draft January 11, 2022 18:42
@bryantbiggs bryantbiggs marked this pull request as ready for review January 11, 2022 18:43
@bryantbiggs
Copy link
Member Author

I was thinking for a second of adding this policy attachment to the root of the module and handling this for users but that only handles one scenario - where users want to attach a policy to ALL roles created. It would get out of hand rather quickly if we take into consideration where users want a policy attached to specific roles or specific node groups, etc. and decided against it. for now, I think the note added is the best course of action for users at this time

README.md Outdated Show resolved Hide resolved
@antonbabenko antonbabenko merged commit f54bd30 into terraform-aws-modules:master Jan 11, 2022
antonbabenko pushed a commit that referenced this pull request Jan 11, 2022
### [18.0.6](v18.0.5...v18.0.6) (2022-01-11)

### Bug Fixes

* Correct remote access variable for security groups and add example for additional IAM policies ([#1766](#1766)) ([f54bd30](f54bd30))
@antonbabenko
Copy link
Member

This PR is included in version 18.0.6 🎉

@bryantbiggs bryantbiggs deleted the fix/remote-access-sgs branch January 11, 2022 21:10
baibailiha added a commit to baibailiha/terraform-aws-eks that referenced this pull request Sep 13, 2022
### [18.0.6](terraform-aws-modules/terraform-aws-eks@v18.0.5...v18.0.6) (2022-01-11)

### Bug Fixes

* Correct remote access variable for security groups and add example for additional IAM policies ([#1766](terraform-aws-modules/terraform-aws-eks#1766)) ([881aa3e](terraform-aws-modules/terraform-aws-eks@881aa3e))
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants