-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Correct remote access variable for security groups and add example for additional IAM policies #1766
fix: Correct remote access variable for security groups and add example for additional IAM policies #1766
Conversation
…le for additional IAM policies
a772cf6
to
60e5d33
Compare
60e5d33
to
7e57033
Compare
I was thinking for a second of adding this policy attachment to the root of the module and handling this for users but that only handles one scenario - where users want to attach a policy to ALL roles created. It would get out of hand rather quickly if we take into consideration where users want a policy attached to specific roles or specific node groups, etc. and decided against it. for now, I think the note added is the best course of action for users at this time |
### [18.0.6](v18.0.5...v18.0.6) (2022-01-11) ### Bug Fixes * Correct remote access variable for security groups and add example for additional IAM policies ([#1766](#1766)) ([f54bd30](f54bd30))
This PR is included in version 18.0.6 🎉 |
### [18.0.6](terraform-aws-modules/terraform-aws-eks@v18.0.5...v18.0.6) (2022-01-11) ### Bug Fixes * Correct remote access variable for security groups and add example for additional IAM policies ([#1766](terraform-aws-modules/terraform-aws-eks#1766)) ([881aa3e](terraform-aws-modules/terraform-aws-eks@881aa3e))
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Description
eks-managed-node-group
to demonstrate shortcomings of additional IAM policies and security groups, providing an explanation and example for how best to utilize these due to Partial/Progressive Configuration Changes hashicorp/terraform#4149Motivation and Context
Breaking Changes
How Has This Been Tested?
examples/*
projectseks-managed-node-group
example