Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add launch_template_tags variable for additional launch template tags #1835

Conversation

kahirokunn
Copy link
Contributor

@kahirokunn kahirokunn commented Feb 3, 2022

Description

add "launch_template_ignore_changes" option

Motivation and Context

If I add a tag to var.tags, it will be added to all of them, but there was a situation where I wanted to add an arbitrary tag only to the specifications_tags of launch_template_tag, and I want to make it supported.

Breaking Changes

How Has This Been Tested?

@kahirokunn kahirokunn changed the title add launch_template_tag_specifications_tags option add "launch_template_tag_specifications_tags" option Feb 3, 2022
@kahirokunn kahirokunn changed the title add "launch_template_tag_specifications_tags" option feat: Add "launch_template_tag_specifications_tags" option Feb 3, 2022
@bryantbiggs
Copy link
Member

I almost forgot - we'll need to update self-managed node groups module as well, and then propagate those changes up to the root node_groups.tf as well - and the title should be updated to reflect - "feat: Add launch_template_tags variable for additional launch template tags"

@kahirokunn kahirokunn changed the title feat: Add "launch_template_tag_specifications_tags" option feat: Add launch_template_tags variable for additional launch template tags Feb 3, 2022
@kahirokunn
Copy link
Contributor Author

@bryantbiggs
I think I did everything you told me to do.
But pre-commit run -a command does not complete no matter how long I wait 😢

@bryantbiggs
Copy link
Member

do you have pre-commit installed? in this repo it can take quite some time - you can get around this with (executed from project root):

  • terraform fmt -recursive .
  • pre-commit run terraform_docs -a

@kahirokunn
Copy link
Contributor Author

@bryantbiggs
It was just like you told me.
I think I've accomplished all the work I needed to!
Thx!

node_groups.tf Outdated Show resolved Hide resolved
node_groups.tf Outdated Show resolved Hide resolved
@kahirokunn
Copy link
Contributor Author

@bryantbiggs how about now?

node_groups.tf Outdated Show resolved Hide resolved
node_groups.tf Outdated Show resolved Hide resolved
kahirokunn and others added 2 commits February 3, 2022 23:29
Co-authored-by: Bryant Biggs <bryantbiggs@gmail.com>
Co-authored-by: Bryant Biggs <bryantbiggs@gmail.com>
@kahirokunn
Copy link
Contributor Author

The correction was omitted.
Sorry about that.

Copy link
Member

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for your efforts @kahirokunn 🎉

good to go 👍🏽 @antonbabenko

@kahirokunn
Copy link
Contributor Author

Thanks for all the advice!
I've learned so much!

@antonbabenko antonbabenko merged commit 9186def into terraform-aws-modules:master Feb 3, 2022
antonbabenko pushed a commit that referenced this pull request Feb 3, 2022
## [18.3.0](v18.2.7...v18.3.0) (2022-02-03)

### Features

* Add launch_template_tags variable for additional launch template tags ([#1835](#1835)) ([9186def](9186def))
@antonbabenko
Copy link
Member

This PR is included in version 18.3.0 🎉

baibailiha added a commit to baibailiha/terraform-aws-eks that referenced this pull request Sep 13, 2022
## [18.3.0](terraform-aws-modules/terraform-aws-eks@v18.2.7...v18.3.0) (2022-02-03)

### Features

* Add launch_template_tags variable for additional launch template tags ([#1835](terraform-aws-modules/terraform-aws-eks#1835)) ([170ea31](terraform-aws-modules/terraform-aws-eks@170ea31))
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants